PHP 8.3 Deprecation Notices and Early Textdomain Load in FV Player

Hi FV Player team,

On WordPress (latest) with PHP 8.3 I’m seeing repeated deprecation notices from FV Player:

PHP Deprecated: Creation of dynamic property FV_Player_Db_Video::$caption is deprecated
in /wp-content/plugins/fv-player/models/db-video.php on lines 452, 467, 505

Suggestion: declare the property on the class to avoid dynamic properties on PHP 8.2+:

// models/db-video.php
class FV_Player_Db_Video {
    /** @var ?string */
    public ?string $caption = null; // prevents dynamic property deprecations
    // ...
}

Alternatively (short-term), adding #[\AllowDynamicProperties] on the class would suppress the deprecation, but declaring the property is the cleaner fix.

I’m also seeing:

PHP Notice: Function _load_textdomain_just_in_time was called incorrectly. Translation loading for the ‘fv-player’ domain was triggered too early.

Recommendation: move load_plugin_textdomain(‘fv-player’, …) to run on init (or later), for example:

add_action('init', function () {
    load_plugin_textdomain('fv-player', false, dirname(plugin_basename(__FILE__)) . '/languages');
});

Thanks for looking into this—happy to test a dev build if helpful.