Forum Replies Created
-
-
Hi Martin,
It’ working! At first it was stuck processing the very first gravatars and did not run the SQL Update to default.png.
After cleaning out the cache folder including the log file, it’s now working just fine (maybe add this to readme.txt for troubleshooting)I suppose this did the trick: stripos( $gravatar, ’404 File does not exist’ ).. when I accessed one of the empty gravatars this was exactly what I received as a message.
I’m not that good at programming, but I think there are some alternatives to fwrite and fopen:
fwrite alternative: file_put_contents()
fopen alternative: file_get_contents()
possibly even curl (more resource hungry thou)
I disabled fopen in my php.ini, I am wondering why it’s working… will double-check that.Thank you for taking the time to fix this plugin so quickly, I will certainly look into your other plugins and consider a donation.
Oliver
The problem might be this:
// check if gravatar exists
$headers = @get_headers( $out );
if( stripos( $headers[0], ‘404’ ) !== FALSE ) {
return $this->GetCacheURL().”default.png”;
}My default (empty) gravatars are all loaded from gravatar.com and your plugin creates files for them. Then your plugin checks for a 404, but the file exists (13 byte).
When I access the file directly it says “404 File does not exist” thou.
Ok this doesn’t make any sense, I need a nap now will try to look into it tomorrow.
I have tried it on two different servers now and on one it works properly so it won’t actually create empty gravatar files for people without gravatars.
On the other it creates a gravatar (empty 13 bytes file) for all comments for some reason.
I suppose it’s because I disabled fopen on one server and it checks via fopen if it’s a default avatar (compare line 437)
Since fopen is a major security risk I would have to rewrite this check.
Ok, looks like all non-gravatars avatars are now broken, I get 404 links.
All users without gravatar (filesize 13 byte) have 404 avatars, but people who actually use gravatars are working just fine.
So.. it must be a problem with the “default” avatars that are created. How do you create/cache those?
