How is this going. Anything available in the latest betas?

> The plugin activation hook in WordPress doesn’t run on plugin updates though, so we will have to find a better way.

Indeed, but many many plugins are doing db migrations during updates. There has to be a best practice mechanism? I just haven’t built a plugin myself with that requirement (yet), so I can’t offer experience-based advice right away.

Ah, indeed, forgot the traceback.

[05-Feb-2019 16:35:06 UTC] WordPress database error Table 'wordpress.wp_fv_player_videos' doesn't exist for query SELECT id, src FROM `wp_fv_player_videos` as v left join ( select id_video from wp_fv_player_videomet
a WHERE meta_key = 'duration' ) as m ON v.id = m.id_video where m.id_video IS NULL ORDER BY id DESC made by include('phar:///usr/local/bin/wp/php/boot-phar.php'), include('phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/wp-cli.php'), WP
_CLI\bootstrap, WP_CLI\Bootstrap\LaunchRunner->process, WP_CLI\Runner->start, WP_CLI\Runner->_run_command_and_exit, WP_CLI\Runner->run_command, WP_CLI\Dispatcher\Subcommand->invoke, call_user_func, WP_CLI\Dispatcher\CommandFactory::WP_CLI
\Dispatcher\{closure}, call_user_func, Cron_Event_Command->run, Cron_Event_Command::run_event, do_action_ref_array('fv_flowplayer_checker_event'), WP_Hook->do_action, WP_Hook->apply_filters, FV_Player_Checker->checker_cron

Admin has been visited by users all the time, but tables were never generated.

Also, you shouldn’t be doing table checking on every request, only on plugin activation.

Thanks. “wp_options” can handle a ton of data (I’m not worried about the table size at all), but yeah must avoid autoloading the rows. You should really find a way to retroactively run the SQL query for other customers, who may not be savvy enough to do it on their own, or even know to search for it as a bug.

Looking forward to the data model migration, but this change alone should certainly work well enough for a while.

Our videos are paid content, public links won’t help.

We could provide one-off access to your support staff when incidents arise. Do you think we could do a simple cross-company Slack channel for posting the links? They have that built in now.

Code still hasn’t been fixed in 0.9.15.

Just curious – do you guys feel like it’s totally OK to keep spamming your customers production site logs with this?

Compared to the in-depth business blog posts at https://foliovision.com/weblog I find the effort here quite disappointing.

Hey guys. This is super simple to fix, what’s the hold up? Every update thus far starts spamming logs again. Here’s some help:

$bShouldBreak = ( $time_now - $time_last > 5 ) ? true : false;  //  insert paragraph break if entries are more than 5 seconds apart
          if( $bShouldBreak ) {
            $time_last_break = $time_now;
          }

          if( $bSentenceEnd && $time_now - $time_last_break > 30 ) {  //  is sentenced has ended previously and it's 30 seconds since last break also insert paragraph break
            $bShouldBreak = true;
            $time_last_break = $time_now;
          }

`$time_last_break` is first initialized inside `if`.

Maybe the simplest thing would be to add `$time_last_break = 0` initialization earlier.

• This reply was modified 8 years, 2 months ago by Eduard.