7.4.21.727: flowplayer::rewrite_embed() may not have `trackback` available

[Solved]

Leho Kraav 5 years, 8 months ago

Hi.

We’re optimizing out some of WP stock rewrite rules, see https://gist.github.com/lkraav/b1d304203038288b8217d8f6bed802d4

trackback is one of them.

This confuses flowplayer::rewrite_embed() which now fails to overtake trackback hierarchy for its own fvp- use (I’m not sure why y’all are doing this in the first place).

When FVP rewrites fail to get added, now flowplayer::rewrite_check() will trigger flush_rewrite_rules() on *every* page load. This is an obvious page load performance killer.

Can y’all migrate away from depending on trackback availability and just add your stuff separately?

Viewing 2 replies - 1 through 2 (of 2 total)

Martin 6 years ago

Hello Leho,

thank you for bringing this to our attention.

We will improve this, in the meantime you can just comment out that flush_rewrite_rules() code in FV Player if you are not using the iframe embed functionality.

Thanks,
Martin

Martin 6 years ago

Hello Leho,

for next FV Player release we have switched to using the add_rewrite_endpoint() WordPress function to add out rewrite rules for the embed codes. Then we still do some filtering to make it compatible with your URL structure. So we no longer check if the rewrite rules are there and you shouldn’t be running into any issues anymore.

You can get the new FV Player version before it’s released here: https://github.com/foliovision/fv-wordpress-flowplayer/archive/384-rewrite-rules.zip

Thanks,
Martin

Viewing 2 replies - 1 through 2 (of 2 total)