Foliovision › Forums › FV Player › Requests and Feedback › Issues with WP Minify
-
-
Hi Wendy,
after having a look at your site we’ve figured out the issue you are facing.
jQuery is loading in the footer, you’d need to move set jQuery to load in the header. If you buy FV Flowplayer 5 we would be happy to give you a hand with modifying your template to allow jQuery to load in the header at which point FV Flowplayer 5 should work fine on your site with your media. You’d probably want a license anyway to remove the watermark.
I hope we get the chance to help you with your upgrade.
Thanks for using Foliovision plugins!
Making the web work for you, Alec
Hello Wendy,
sure, it’s better to load all the JavaScript in the footer.
However it should be done by moving the internal WordPress JavaScript loading routines (wp_enqueue_scripts() adds scripts into a list of what to load, wp_print_scripts() prints them into HTML) from wp_head to wp_footer. That would be our general recommendation.
We want to add some detection of this issue into our plugin.
Thanks,
MartinYes, I use this plugin. I didn’t realize that it didn’t use the enqueue scripts method:
http://omninoggin.com/wordpress-plugins/wp-minify-wordpress-plugin/
http://wordpress.org/plugins/wp-minify/Since it has over 300,000 downloads, this may not be an isolated issue,
Thanks,
WendyHello Wendy,
Could you please post us a screenshot of your WP Minify settings, so we can troubleshoot with exactly your settings which seemed to cause issues? Or at least a written description of what exactly you have turned on.
We are releasing a new version of the plugin today which has integrated template checks and also detects WP Minify to warn users about possible issues.
Thanks,
MartinHi Martin,
my WP Minify settings are pretty basic.
The only thing checked in advanced settings is Automatically set your Minify base per siteurl setting (recommended) It looks like I don’t have this checked in advanced settings: “Place Minified JavaScript in footer (Not recommended, more info)”
Nothing else seems to be different than default in advanced.
W
Hello Wendy,
sorry about not reporting back to you earlier.
I finally tested WP Minify with our plugin and it works with the latest version. It should be fine since version 2.1.8, released at the end of May.
We don’t recommend enabling “Place Minified JavaScript in footer”, as it stops the front-end admin video checks and “Default (mixed)” “Preferred Flowplayer engine” option from working. You mentioned you are not using this option, so there should be no issues.
However if you only load your jQuery in footer, I’m not sure if it will work. The only way to make WP Minify aware of your jQuery script is to make sure it uses the wp_enqueue_script function to load. Since you already use the minify, it makes sure to just minify all the scripts with it and not exclude jQuery and then put it into footer manually.
We added a check for this settings into the “Check Template” button on the FV Flowplayer settings screen.
Thanks,
Martin