-
I cannot find a shortcode format that will let me pass a caption (colorbox title) to the lightbox when using the <a> text link shortcode, as below
[fvplayer src="..." lightbox="true;text;This is the lightbox caption" caption="This is the link text" splash="..."]
It seems that the code parsing the “lightbox” param isn’t expecting both the ‘text’ keyword (meaning not to use a splash image) AND a text string to use as a colorbox title.
-
-
Hello,
thank you for the bug report.
We fixed the lightbox caption display which stopped working in 6.5.1 and also enabled use of lightbox=”true;text;This is the lightbox caption”. We also finally wrote some automated tests for this.
If you could test the new version before we release it, that would be great, just reinstall the plugin from this ZIP file: https://github.com/foliovision/fv-wordpress-flowplayer/archive/master.zip
Thanks,
MartinHi Martin –
The functionality looks great on my test page:
http://twigpress.aws.twiginteractive.com/Only thing I see for text link, is that if you edit the shortcode in the visual view, the FV pop up doesn’t like parsing the lightbox args, and so show “NaN Nan”. Probably trying to cast those strings to integers for width/height. Not a killer but I’m sure less technical people might be confused? If you hit ‘update’ it removes the params completely.
Hello,
thank you for noticing that issue.
Unfortunately I had to remove support for the lightbox=”true;text;This is the lightbox caption” kind of shortcode as we are trying to standardize things and move to a database model for FV Player and this would only make it more confusing.
The link text (the caption=”” attribute of the shortcode) will still show as the lightbox caption, hopefully that will be enough for your use.
Thanks,
MartinAh, that’s a shame. Hopefully in your standardization you are going to support this feature? It’s quite often the case that the link text will need to be different from the caption (usually it’s shorter). Seems like the shortcode needs another param “splashImage” or something that would be a checkbox in the UI so that a text lightbox and an image lightbox are independently controlled.
Thanks anyway – it’s a great plugin!
Hi – can you bump the version on the WP repo from 6.5.2 to 6.6? Right now it’s not prompting to update to get the fix for this.
Thanks
Hello,
we had to hold that update for a bit as we discovered there was a bug when updating when using FV Player Pro 0.9.17 beta.
It’s out now.
Thanks,
MartinPerfect – thanks!
