-
Hello,
v. 7.4.34 causes multiple ‘***/wp-includes/pomo/plural-forms.php on line 275’ errors on a page that contains videos
-
-
Hello Edward,
thank you for the bug report, could you please send over the full log entries? We will remove any sensitive part which it might contain.
Also, what language are you using?
I wonder what could be the issue there as we use the WordPress _n() PHP function according to their docs.
Thanks,
Martin
Hello Martin,
I use the latest wordpress 5.5.1–ru_RU (Russian).
The errors appear on the bottom of a test page that contains 8 fv videos with diff. settings for testing. But there are only 6 errors (see below). I think it somehow connected with aws/cloudfront videos. The page contains 6 aws/cloudfront videos, 1 local and 1 video by link from another site.
Warning: A non-numeric value encountered in .../wp-includes/pomo/plural-forms.php on line 275 Warning: A non-numeric value encountered in .../wp-includes/pomo/plural-forms.php on line 275 Warning: A non-numeric value encountered in .../wp-includes/pomo/plural-forms.php on line 275 Warning: A non-numeric value encountered in .../wp-includes/pomo/plural-forms.php on line 275 Warning: A non-numeric value encountered in .../wp-includes/pomo/plural-forms.php on line 275 Warning: A non-numeric value encountered in .../wp-includes/pomo/plural-forms.php on line 275
Update: I was looking through another test page with much more number of videos. There are still only 6 errors.
Hello Edward,
I get that same issue when I switch to Russian. The translated phrases which I get are:
duration_1_day: "%s день" duration_1_hour: "%s час" duration_1_minute: "%s minute" duration_1_second: "%s second" duration_n_days: "%s дней" duration_n_hours: "%s часов" duration_n_minutes: "%s minutes" duration_n_seconds: "%s seconds"
So it appears it fails to translate a couple of these.
We are looking into it.
Thanks,
Martin
Hello Martin,
i think these phrases are used by the plugin internally. I don’t use them in clear text on the page.
JFYI: 7.4.33.727 version has no such bug, so it can be easily reproduced by installing 7.4.34 and it disappears when I rollback plugin to 7.4.33
these phrases has a mix of English and Russian. It seems like a mistake.
it should be:
duration_1_day: “%s день”
duration_1_hour: “%s час”
duration_1_minute: “%s минута”
duration_1_second: “%s секунда”
duration_n_days: “%s дней”
duration_n_hours: “%s часов”
duration_n_minutes: “%s минут”
duration_n_seconds: “%s секунд”
Hello Edward,
we are working on the fix, here the work in progress version of FV Player in case you want to help with testing: https://github.com/foliovision/fv-wordpress-flowplayer/archive/524-plural-froms-fix.zip
Thanks,
Martin
Hello Martin,
as a quick response there are now these errors after installing this version.
Hello Edward,
unfortunately we didn’t get any errors in your message. Perhaps you hit the reply button before the image has finished uploading or you pasted in too much HTML code.
Thanks,
Martin
Hello Martin,
sorry for the typo. After installing this version i didn’t have these errors
Hello Edward,
thank you for the confirmation. We will make the fix part of the next FV Player release.
Thanks,
Martin
Hello Martin,
thank you for your support.
