-
Deprecated stripos(): Non-string needles will be interpreted as strings in the future. Use an explicit chr() call to preserve the current behavior
hybrid_get_content_template() /home/convers/deploy/cxl/hbd-institute-theme/releases/20190429.204249-leho/index.php:23 the_content() /home/convers/deploy/cxl/institute-theme/releases/20190530.172725-paul/content/page.php:57 apply_filters('the_content') wp-includes/post-template.php:247 do_shortcode() wp-includes/class-wp-hook.php:286 preg_replace_callback() wp-includes/shortcodes.php:199 do_shortcode_tag() Unknown location Grid_Columns->do_shortcode() wp-includes/shortcodes.php:325 apply_filters('gc_column_content') wp-content/plugins/grid-columns.git/grid-columns.php:259 do_shortcode() wp-includes/class-wp-hook.php:288 preg_replace_callback() wp-includes/shortcodes.php:199 do_shortcode_tag() Unknown location flowplayer_content_handle() wp-includes/shortcodes.php:325 flowplayer_frontend->build_min_player() wp-content/plugins/fv-wordpress-flowplayer/controller/shortcodes.php:162 apply_filters('fv_flowplayer_args_pre') wp-content/plugins/fv-wordpress-flowplayer/models/flowplayer-frontend.php:86 FV_Player_SEO->should_i() wp-includes/class-wp-hook.php:286 flowplayer_frontend->get_splash() wp-content/plugins/fv-wordpress-flowplayer/models/seo.php:76 apply_filters('fv_flowplayer_splash') wp-content/plugins/fv-wordpress-flowplayer/models/flowplayer-frontend.php:959 FV_Player_Pro->get__cached_splash() wp-includes/class-wp-hook.php:288 stripos() wp-content/plugins/fv-player-pro/beta/fv-player-pro.class.php:3548Hopefully stack trace is readable. There’s no preview function so can’t tell up front.
-
-
We’re at 7.4.9.727 and this is still a major log spam source.
[22-Jan-2020 08:13:17 UTC] PHP Notice: get__cached_splash stripos needle is unexpectedly not a string: #0 /home/convers/public_html/institute/wp-includes/class-wp-hook.php(290): FV_Player_Pro->get__cached_splash(false)
#1 /home/convers/public_html/institute/wp-includes/plugin.php(206): WP_Hook->apply_filters(false, Array)
#2 /home/convers/public_html/institute/wp-content/plugins/fv-wordpress-flowplayer/models/flowplayer-frontend.php(983): apply_filters(‘fv_flowplayer_s…’, false, Object(flowplayer_frontend))
#3 /home/convers/public_html/institute/wp-content/plugins/fv-wordpress-flowplayer/models/seo.php(76): flowplayer_frontend->get_splash()
#4 /home/convers/public_html/institute/wp-includes/class-wp-hook.php(288): FV_Player_SEO->should_i(Array)
#5 /home/convers/public_html/institute/wp-includes/plugin.php(206): WP_Hook->apply_filters(Array, Array)
#6 /home/convers/public_html/institute/wp-content/plugins/fv-wordpress-flowplayer/models/flowplayer-frontend.php(86): apply_filters(‘fv_flowplayer_a…’, Array)
#7 /home/convers/public_html/institute/w in /home/convers/public_html/institute/wp-content/plugins/fv-player-pro/fv-player-pro.class.php on line 3685Can yall figure this out?
Hello,
Thanks for letting us know! I’ve forwarded this issue to our development team for a check.
We’ll get in touch with you in the close future with more info.
Thanks for being part of Foliovision,
JurajThanks. I forgot to add y-day, that my debugging showed $src parameter occasionally being NULL instead of a string. I ran out of time and couldn’t quite tell what video source produces this situation. Let me know if you need more information about the inputs.
Hello CXL,
FV Player and FV Player Pro 7.4.14.727 were released. They use a simpler code around these automated splash images for Vimeo and YouTube images which will get rid of your warning. That edge case under which it was appearing should also no longer occur. It was not using a proper variable to pass the video source URL, but a full object which was hard to manage and there was no reason for it.
Thanks,
MartinWIth 7.4.14.727, logs are flooded with “[29-Jan-2020 12:10:33 UTC] PHP Notice: Undefined variable: src in /home/convers/public_html/institute/wp-content/plugins/fv-player-pro/fv-player-pro.class.php on line 3680”
Traceback:
wp-content/plugins/fv-player-pro/fv-player-pro.class.php:3680
FV_Player_Pro->get__cached_splash()
wp-includes/class-wp-hook.php:288
apply_filters(‘fv_flowplayer_splash’)
wp-content/plugins/fv-wordpress-flowplayer/models/flowplayer-frontend.php:983
flowplayer_frontend->get_splash()
wp-content/plugins/fv-wordpress-flowplayer/models/seo.php:76
FV_Player_SEO->should_i()
wp-includes/class-wp-hook.php:288
apply_filters(‘fv_flowplayer_args_pre’)
wp-content/plugins/fv-wordpress-flowplayer/models/flowplayer-frontend.php:86
flowplayer_frontend->build_min_player()
wp-content/plugins/fv-wordpress-flowplayer/controller/shortcodes.php:195
flowplayer_content_handle()
wp-includes/shortcodes.php:325
do_shortcode_tag()
Unknown location
preg_replace_callback()
wp-includes/shortcodes.php:199
do_shortcode()
wp-includes/class-wp-hook.php:288
apply_filters(‘the_content’)
wp-includes/post-template.php:253
the_content()
/home/convers/deploy/cxl/institute-theme/releases/20200104.143555-leho/content/lesson-singular.php:47
hybrid_get_content_template()
/home/convers/deploy/cxl/hbd-institute-theme/releases/20200122.151833-leho/sensei.php:23Are you guys using IntelliJ / PhpStorm? IDE-s and of course any static analysis tools would’ve caught this pre-release.
Hello CXL,
FV Player Pro 7.4.15.727 is out and it fixes this issue.
The issue was not running the unit tests on the Release version of the plugin, only Beta where these changes were made first. Thank you for your recommendation, I’m trying out phpstan.
Thanks,
MartinHello CXL,
the issue with PHP static analysis is that we would have to rewrite our classes to use autoload. Besides that I don’t think it would catch an issue like this, as it uses the WordPress filters API.
The WordPress filters are not such a great idea when you develop your own plugin after all. If we would use PHP classes instead and extend them, this would be easier to test with PHPUnit too.
Thanks,
Martin
